package/psplash: add support for two configure options

Check-list

  • I did not find the issue in the existing issues
  • I can reproduce the issue with unmodified Buildroot from this repository, not from a fork somewhere else
  • I can reproduce the issue on the latest commit of the branch I'm using:
    • master
    • stable (i.e. 20NN.MM.x - please specify)
    • LTS (2025.02.1)
  • I can reproduce the issue after running make clean; make
  • I attached the full build log file (e.g. make 2>&1 |tee build.log)
  • I attached a minimal defconfig file that can reproduce the issue (make BR2_DEFCONFIG=$(pwd)/issue_defconfig savedefconfig)
  • I also attached the configuration for kconfig-based packages that are enabled (and necessary to reproduce the issue), most notably:
    • busybox
    • linux
    • uclibc
    • uboot
    • …

What I did

  • Buildroot commit sha1: 2025.02.1
  • Distribution of the build machine: Ubuntu 22.04

What happens

When using the option to display the progress bar in psplash in the buildroot menuconfig, which is the default behavior, the progress bar is not displayed in psplash. The build log for psplash is attached

What was expected

The progress bar in psplash should appear

Extra information

The option --enable-progress-bar does not exist in psplash, there is only --disable-progress-bar (https://git.yoctoproject.org/psplash/commit/?id=44afb7506d43cca15582b4c5b90ba5580344d75d)

I think the issue was introduced with this commit 5da83ec5 which should have been

diff --git a/package/psplash/psplash.mk b/package/psplash/psplash.mk
index 69f9bf386da0a6b3463a30b7b8a7b09ad9017819..62268e778b03e1f995db9d4e470e3d372f770cef 100644
--- a/package/psplash/psplash.mk
+++ b/package/psplash/psplash.mk
@@ -19,6 +19,18 @@ else
 PSPLASH_CONF_OPTS += --without-systemd
 endif
 
+ifneq ($(BR2_PACKAGE_PSPLASH_PROGRESS_BAR),y)
+PSPLASH_CONF_OPTS += --disable-progress-bar
+endif
+
+ifneq ($(BR2_PACKAGE_PSPLASH_STARTUP_MSG),y)
+PSPLASH_CONF_OPTS += --disable-startup-msg
+endif
+
 PSPLASH_IMAGE = $(call qstrip,$(BR2_PACKAGE_PSPLASH_IMAGE))
 
 ifneq ($(PSPLASH_IMAGE),)

I can see the progress-bar when I modify the psplash.mk to look like this patch.

Here is the build log of psplash. We can see that --enable-progress-bar is passed, but the build string still contains -DPSPLASH_DISABLE_PROGRESS_BAR which makes the progress bar disabled in the end build-psplash.log