Skip to content
GitLab Next
Switch branch/tag
  1. 14 Mar, 2022 1 commit
  3. 05 Mar, 2022 1 commit
    • Warner Losh's avatar
      umtx: Properly batch utmx operations · ab12ac38
      Warner Losh authored 
      

Store the converted pointers correctly when passing 32-bit calls through
to the kernel.  Before we'd store them all in location 0, now we spread
them through the array as intended. This allows us to now past the
umtx_op_test which was failing before.

This likely should be merged to the 3.1 branch if this doesn't cause a
enough improvement to the blitz branch to switch the port over to it.
Signed-off-by: Warner Losh's avatarWarner Losh <imp@bsdimp.com>
      ab12ac38
  5. 26 Feb, 2022 2 commits
  7. 24 Feb, 2022 1 commit
    • Peter Maydell's avatar
      Merge remote-tracking branch 'remotes/jsnow-gitlab/tags/python-pull-request' into staging · fa435db8
      Peter Maydell authored 
      

Python patches

New functionality in qmp-shell from Dan, and some packaging fixes.

# gpg: Signature made Wed 23 Feb 2022 22:08:35 GMT
# gpg:                using RSA key F9B7ABDBBCACDF95BE76CBD07DEF8106AAFC390E
# gpg: Good signature from "John Snow (John Huston) <jsnow@redhat.com>" [full]
# Primary key fingerprint: FAEB 9711 A12C F475 812F  18F2 88A9 064D 1835 61EB
#      Subkey fingerprint: F9B7 ABDB BCAC DF95 BE76  CBD0 7DEF 8106 AAFC 390E

* remotes/jsnow-gitlab/tags/python-pull-request:
  MAINTAINERS: python - remove ehabkost and add bleal
  Revert "python: pin setuptools below v60.0.0"
  Python: add setuptools v60.0 workaround
  Python: discourage direct setup.py install
  python: support recording QMP session to a file
  python: introduce qmp-shell-wrap convenience tool
Signed-off-by: Peter Maydell's avatarPeter Maydell <peter.maydell@linaro.org>
      fa435db8
  9. 23 Feb, 2022 7 commits
    • John Snow's avatar
      MAINTAINERS: python - remove ehabkost and add bleal · 89d38c74
      John Snow authored 
      

Eduardo Habkost has left Red Hat and has other daily responsibilities to
attend to. In order to stop spamming him on every series, remove him as
"Reviewer" for the python/ library dir and add Beraldo Leal instead.

For the "python scripts" stanza (which is separate due to level of
support), replace Eduardo as maintainer with myself.

(Thanks for all of your hard work, Eduardo!)
Signed-off-by: John Snow's avatarJohn Snow <jsnow@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé's avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Beraldo Leal's avatarBeraldo Leal <bleal@redhat.com>
Acked-by: Eduardo Habkost's avatarEduardo Habkost <eduardo@habkost.net>
Message-id: 20220208000525.2601011-1-jsnow@redhat.com
Signed-off-by: John Snow's avatarJohn Snow <jsnow@redhat.com>
      89d38c74
    • John Snow's avatar
      Revert "python: pin setuptools below v60.0.0" · 43a1119e
      John Snow authored 
      This reverts commit 1e4d8b31

.
Signed-off-by: John Snow's avatarJohn Snow <jsnow@redhat.com>
Message-id: 20220204221804.2047468-3-jsnow@redhat.com
Signed-off-by: John Snow's avatarJohn Snow <jsnow@redhat.com>
      43a1119e
    • John Snow's avatar
      Python: add setuptools v60.0 workaround · 762c280d
      John Snow authored 
      Setuptools v60 and later include a bundled version of distutils, a
deprecated standard library scheduled for removal in future versions of
Python. Setuptools v60 is only possible to install for Python 3.7 and later.

Python has a distutils.sysconfig.get_python_lib() function that returns
'/usr/lib/pythonX.Y' on posix systems. RPM-based systems actually use
'/usr/lib64/pythonX.Y' instead, so Fedora patches stdlib distutils for
Python 3.7 and Python 3.8 to return the correct value.

Python 3.9 and later introduce a sys.platlibdir property, which returns
the correct value on RPM-based systems.

The change to a distutils package not provided by Fedora on Python 3.7
and 3.8 causes a regression in distutils.sysconfig.get_python_lib() that
ultimately causes false positives to be emitted by pylint, because it
can no longer find the system source libraries.

Many Python tools are fairly aggressive about updating setuptools
packages, and so even though this package is a fair bit newer than
Python 3.7/3.8, it's not entirely unreasonable for a given user to have
such a modern package with a fairly old Python interpreter.

Updates to Python 3.7 and Python 3.8 are being produced for Fedora which
will fix the problem on up-to-date systems. Until then, we can force the
loading of platform-provided distutils when running the pylint
test. This is the least-invasive yet most comprehensive fix.

References:
 https://github.com/pypa/setuptools/pull/2896
 https://github.com/PyCQA/pylint/issues/5704
 https://github.com/pypa/distutils/issues/110

Signed-off-by: John Snow's avatarJohn Snow <jsnow@redhat.com>
Message-id: 20220204221804.2047468-2-jsnow@redhat.com
Signed-off-by: John Snow's avatarJohn Snow <jsnow@redhat.com>
      762c280d
    • John Snow's avatar
      Python: discourage direct setup.py install · 2ddaeb7b
      John Snow authored 
      

When invoking setup.py directly, the default behavior for 'install' is
to run the bdist_egg installation hook, which is ... actually deprecated
by setuptools. It doesn't seem to work quite right anymore.

By contrast, 'pip install' will invoke the bdist_wheel hook
instead. This leads to differences in behavior for the two approaches. I
advocate using pip in the documentation in this directory, but the
'setup.py' which has been used for quite a long time in the Python world
may deceptively appear to work at first glance.

Add an error message that will save a bit of time and frustration
that points the user towards using the supported installation
invocation.
Reported-by: Daniel P. Berrangé's avatarDaniel P. Berrangé <berrange@redhat.com>
Signed-off-by: John Snow's avatarJohn Snow <jsnow@redhat.com>
Reviewed-by: Beraldo Leal's avatarBeraldo Leal <bleal@redhat.com>
Message-id: 20220207213039.2278569-1-jsnow@redhat.com
Signed-off-by: John Snow's avatarJohn Snow <jsnow@redhat.com>
      2ddaeb7b
    • Daniel P. Berrangé's avatar
      python: support recording QMP session to a file · 5c66d7d8
      Daniel P. Berrangé authored and John Snow's avatar John Snow committed 
      

When running QMP commands with very large response payloads, it is often
not easy to spot the info you want. If we can save the response to a
file then tools like 'grep' or 'jq' can be used to extract information.

For convenience of processing, we merge the QMP command and response
dictionaries together:

  {
      "arguments": {},
      "execute": "query-kvm",
      "return": {
          "enabled": false,
          "present": true
      }
  }

Example usage

  $ ./scripts/qmp/qmp-shell-wrap -l q.log -p -- ./build/qemu-system-x86_64 -display none
  Welcome to the QMP low-level shell!
  Connected
  (QEMU) query-kvm
  {
      "return": {
          "enabled": false,
          "present": true
      }
  }
  (QEMU) query-mice
  {
      "return": [
          {
              "absolute": false,
              "current": true,
              "index": 2,
              "name": "QEMU PS/2 Mouse"
          }
      ]
  }

 $ jq --slurp '. | to_entries[] | select(.value.execute == "query-kvm") |
               .value.return.enabled' < q.log
   false
Reviewed-by: Philippe Mathieu-Daudé's avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Daniel P. Berrangé's avatarDaniel P. Berrangé <berrange@redhat.com>
Message-id: 20220128161157.36261-3-berrange@redhat.com
Signed-off-by: John Snow's avatarJohn Snow <jsnow@redhat.com>
      5c66d7d8
    • Daniel P. Berrangé's avatar
      python: introduce qmp-shell-wrap convenience tool · 43912529
      Daniel P. Berrangé authored and John Snow's avatar John Snow committed 
      

With the current 'qmp-shell' tool developers must first spawn QEMU with
a suitable -qmp arg and then spawn qmp-shell in a separate terminal
pointing to the right socket.

With 'qmp-shell-wrap' developers can ignore QMP sockets entirely and
just pass the QEMU command and arguments they want. The program will
listen on a UNIX socket and tell QEMU to connect QMP to that.

For example, this:

 # qmp-shell-wrap -- qemu-system-x86_64 -display none

Is roughly equivalent of running:

 # qemu-system-x86_64 -display none -qmp qmp-shell-1234 &
 # qmp-shell qmp-shell-1234

Except that 'qmp-shell-wrap' switches the socket peers around so that
it is the UNIX socket server and QEMU is the socket client. This makes
QEMU reliably go away when qmp-shell-wrap exits, closing the server
socket.
Signed-off-by: Daniel P. Berrangé's avatarDaniel P. Berrangé <berrange@redhat.com>
Message-id: 20220128161157.36261-2-berrange@redhat.com
[Edited for rebase. --js]
Signed-off-by: John Snow's avatarJohn Snow <jsnow@redhat.com>
      43912529
    • Peter Maydell's avatar
      Merge remote-tracking branch 'remotes/berrange-gitlab/tags/misc-next-pull-request' into staging · 4aa2e497
      Peter Maydell authored 
      This misc series of changes:

 - Improves documentation of SSH fingerprint checking
 - Fixes SHA256 fingerprints with non-blockdev usage
 - Blocks the clone3, setns, unshare & execveat syscalls
   with seccomp
 - Blocks process spawning via clone syscall, but allows
   threads, with seccomp
 - Takes over seccomp maintainer role
 - Expands firmware descriptor spec to allow flash
   without NVRAM

# gpg: Signature made Thu 17 Feb 2022 11:57:13 GMT
# gpg:                using RSA key DAF3A6FDB26B62912D0E8E3FBE86EBB415104FDF
# gpg: Good signature from "Daniel P. Berrange <dan@berrange.com>" [full]
# gpg:                 aka "Daniel P. Berrange <berrange@redhat.com>" [full]
# Primary key fingerprint: DAF3 A6FD B26B 6291 2D0E  8E3F BE86 EBB4 1510 4FDF

* remotes/berrange-gitlab/tags/misc-next-pull-request:
  docs: expand firmware descriptor to allow flash without NVRAM
  MAINTAINERS: take over seccomp from Eduardo Ot...
      4aa2e497
  11. 22 Feb, 2022 5 commits
    • Peter Maydell's avatar
      Merge remote-tracking branch... · 31e3caf2
      Peter Maydell authored 
      
Merge remote-tracking branch 'remotes/lvivier-gitlab/tags/trivial-branch-for-7.0-pull-request' into staging

Trivial branch pull request 20220222

# gpg: Signature made Tue 22 Feb 2022 16:16:01 GMT
# gpg:                using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C
# gpg:                issuer "laurent@vivier.eu"
# gpg: Good signature from "Laurent Vivier <lvivier@redhat.com>" [full]
# gpg:                 aka "Laurent Vivier <laurent@vivier.eu>" [full]
# gpg:                 aka "Laurent Vivier (Red Hat) <lvivier@redhat.com>" [full]
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C

* remotes/lvivier-gitlab/tags/trivial-branch-for-7.0-pull-request:
  hid: Implement support for side and extra buttons
  vdpa: Make ncs autofree
  qemu-options: fix incorrect description for '-drive index='
  hw/nvram: use at24 macro
  target/rx: Remove unused ENV_OFFSET definition
  target/avr: Correct AVRCPUClass docstring
  configure: Disable capstone and slirp in the --without-default-features mode
Signed-off-by: Peter Maydell's avatarPeter Maydell <peter.maydell@linaro.org>
      31e3caf2
    • Noah Bergbauer's avatar
      hid: Implement support for side and extra buttons · 1e2d5558
      Noah Bergbauer authored and LAURENT VIVIER's avatar LAURENT VIVIER committed 
      

Simply set the respective bits and update the descriptor accordingly.
Signed-off-by: default avatarNoah Bergbauer <noah@statshelix.com>
Acked-by: Gerd Hoffmann's avatarGerd Hoffmann <kraxel@redhat.com>
Message-Id: <20211126140437.79745-1-noah@statshelix.com>
Signed-off-by: LAURENT VIVIER's avatarLaurent Vivier <laurent@vivier.eu>
      1e2d5558
    • Eugenio Pérez's avatar
      vdpa: Make ncs autofree · eb3cb751
      Eugenio Pérez authored and LAURENT VIVIER's avatar LAURENT VIVIER committed 
      

Simplifying memory management.
Signed-off-by: Eugenio Pérez's avatarEugenio Pérez <eperezma@redhat.com>
Acked-by: Jason Wang's avatarJason Wang <jasowang@redhat.com>
Reviewed-by: Stefano Garzarella's avatarStefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé's avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220214193415.1606752-2-eperezma@redhat.com>
Signed-off-by: LAURENT VIVIER's avatarLaurent Vivier <laurent@vivier.eu>
      eb3cb751
    • Laurent Vivier's avatar
      qemu-options: fix incorrect description for '-drive index=' · 35aab303
      Laurent Vivier authored and LAURENT VIVIER's avatar LAURENT VIVIER committed 
      qemu-options.hx contains grammar that a native English-speaking
person would never use.

Replace "This option defines where is connected the drive" by
"This option defines where the drive is connected".

Fixes: qemu-project/qemu#853

Signed-off-by: Laurent Vivier's avatarLaurent Vivier <lvivier@redhat.com>
Reviewed-by: Thomas Huth's avatarThomas Huth <thuth@redhat.com>
Message-Id: <20220202143422.912070-1-lvivier@redhat.com>
Signed-off-by: LAURENT VIVIER's avatarLaurent Vivier <laurent@vivier.eu>
      35aab303
    • Peter Maydell's avatar
      Merge remote-tracking branch 'remotes/thuth-gitlab/tags/pull-request-2022-02-21' into staging · 5abccc79
      Peter Maydell authored 
      

* Improve virtio-net failover test
* Some small fixes for the qtests
* Misc header cleanups by Philippe

# gpg: Signature made Mon 21 Feb 2022 11:40:37 GMT
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [full]
# gpg:                 aka "Thomas Huth <thuth@redhat.com>" [full]
# gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [full]
# gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* remotes/thuth-gitlab/tags/pull-request-2022-02-21: (25 commits)
  hw/tricore: Remove unused and incorrect header
  hw/m68k/mcf: Add missing 'exec/hwaddr.h' header
  exec/exec-all: Move 'qemu/log.h' include in units requiring it
  softmmu/runstate: Clean headers
  linux-user: Add missing "qemu/timer.h" include
  target: Add missing "qemu/timer.h" include
  core/ptimers: Remove unnecessary 'sysemu/cpus.h' include
  exec/ramblock: Add missing includes
  qtest: Add missing 'hw/qdev-core.h' include
  hw/acpi/memory_hotplug: Remove unused 'hw/acpi/pc-hotplug.h' header
  hw/remote: Add missing include
  hw/tpm: Clean includes
  scripts: Remove the old switch-timer-api script
  tests/qtest: failover: migration abort test with failover off
  tests/qtest: failover: test migration if the guest doesn't support failover
  tests/qtest: failover: check migration with failover off
  tests/qtest: failover: check missing guest feature
  tests/qtest: failover: check the feature is correctly provided
  tests/qtest: failover: use a macro for check_one_card()
  tests/qtest: failover: clean up pathname of tests
  ...
Signed-off-by: Peter Maydell's avatarPeter Maydell <peter.maydell@linaro.org>
      5abccc79
  13. 21 Feb, 2022 23 commits