Switched click outside handling in modals and contexts to `mousedown` rather than `click` event.
Merge Request Checklist
-
changelog.md has been updated if required -
New/updated Premium features are separated correctly in the premium folder -
The latest Chrome and Firefox have been used to test any new frontend features -
Documentation has been updated -
Quality Standards are met -
Performance: tables are still fast with 100k+ rows, 100+ field tables -
The redoc API pages have been updated for any REST API changes -
Our custom API docs are updated for changes to endpoints accessed via api tokens -
The UI/UX has been updated following UI Style Guide
Closes #1243 (closed)
Merge request reports
Activity
marked the checklist item changelog.md has as completed
- Resolved by Abdalla Mahmoud
Hey @abdalla5,
Thank you very much for your contribution, we really appreciate that!
Well done on creating an issue first and then a related merge request, it helps us keep track of everything
🙂 I tested the fix and it works really well, it makes sense to change the event listener to
mousedown
overclick
, given what you have explained in your issue!If you could have a look at a minor suggestion made to the changelog entry and update the MR accordingly, I am more than happy to get this merged asap :).
requested review from @alex1431999
assigned to @abdalla5
added MRunresolved feedback 💬 label
marked the checklist item The redoc API pages have been updated for any as completed
marked the checklist item Quality Standards as completed
marked the checklist item Documentation has been as completed
added MRcan be merged ✅ label and removed MRunresolved feedback 💬 label
enabled an automatic merge when the pipeline for 58e75933 succeeds
mentioned in commit eada1fd8
mentioned in merge request !1044 (merged)