GitLab-15-Breaking-Changes.md

@@ -866,6 +866,28 @@ Announced in 13.12
 
 Configuring the Gitaly nodes directly in the virtual storage's root configuration object has been deprecated in GitLab 13.12 and is no longer supported in GitLab 15.0. You must move the Gitaly nodes under the `'nodes'` key as described in [the Praefect configuration](https://docs.gitlab.com/ee/administration/gitaly/praefect.html#praefect).
 
+
+#### :ballot_box_with_check: Gitaly Cluster :fax:
+
+- GitLab doesn't use Gitaly cluster by default.
+- Only affects sites where Gitaly cluster has been set up, and this requires a separate database, at least one Praefect server, usually more, and usually multiple dedicated Gitaly servers.
+- Check `gitlab.rb` and verify that on the praefect servers that the data structure that defines the Gitaly nodes is consistent with the documentation as linked above.  In particular `nodes' => {` is required:
+
+```ruby
+praefect['virtual_storages'] = {
+  'default' => {
+    'nodes' => {
+      'gitaly-1' => {
+      },
+      'gitaly-2' => {
+      },
+      'gitaly-3' => {
+      }
+    }
+  }
+}
+```
+
 ### Move Gitaly Cluster Praefect `database_host_no_proxy` and `database_port_no_proxy configs`
 
 Announced in 14.0
@@ -875,6 +897,13 @@ The Gitaly Cluster configuration keys for `praefect['database_host_no_proxy']` a
 
 - [Issue](https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/6150)
 
+#### :ballot_box_with_check: Gitaly Cluster  :fax:
+
+- GitLab doesn't use Gitaly cluster by default.
+- Only affects sites where Gitaly cluster has been set up, and this requires a separate database, at least one Praefect server, usually more, and usually multiple dedicated Gitaly servers.
+- Check `gitlab.rb` on the praefect servers for the `no_proxy` settings specified.
+- [Read more in the docs](https://docs.gitlab.com/ee/administration/gitaly/praefect.html#reads-distribution-caching)   about what the `database_direct` settings are for 
+
 ---
 
 ### Move `custom_hooks_dir` setting from GitLab Shell to Gitaly
@@ -886,6 +915,28 @@ The [`custom_hooks_dir`](https://docs.gitlab.com/ee/administration/server_hooks.
 
 - [Issue](https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/4208)
 
+#### :ballot_box_with_check:  gitlab.rb  :gear:  
+
+- Check `gitlab.rb`:
+
+```shell
+grep custom_hooks_dir /etc/gitlab/gitlab.rb  | egrep -v '^#'
+```
+
+If you find the old `gitlab_shell['custom_hooks_dir']` setting enabled ...
+
+```ruby
+# gitlab_shell['custom_hooks_dir'] = "/opt/gitlab/embedded/service/gitlab-shell/hooks"
+```
+
+... replace it with `gitaly['custom_hooks_dir']`.
+
+```ruby
+# gitaly['custom_hooks_dir'] = "/var/opt/gitlab/gitaly/custom_hooks"`
+```
+
+This can be done in GitLab 14.3 or higher, as the example configuration template [was changed to the new setting](https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/4208) in 14.3, its only in 15.0 that the old setting stops working.
+
 ---
 
 ### Pseudonymizer
@@ -898,6 +949,36 @@ It was removed in GitLab 15.0.
 
 - [Issue](https://gitlab.com/gitlab-org/gitlab/-/issues/219952)
 
+#### :ballot_box_with_check: Ultimate feature :sparkles:,  gitlab.rb  :gear:  
+
+- This was an ultimate feature
+- Check `gitlab.rb`:
+
+```shell
+grep pseudonymizer /etc/gitlab/gitlab.rb  | egrep -v '^#'
+```
+
+At least [some of these settings](https://gitlab.com/gitlab-org/omnibus-gitlab/blob/14.10.0+ee.0/files/gitlab-config-template/gitlab.rb.template#L627) would be needed:
+
+```ruby
+# gitlab_rails['pseudonymizer_worker_cron'] = "0 23 * * *"
+### Pseudonymizer Settings
+# gitlab_rails['pseudonymizer_manifest'] = 'config/pseudonymizer.yml'
+# gitlab_rails['pseudonymizer_upload_remote_directory'] = 'gitlab-elt'
+# gitlab_rails['pseudonymizer_upload_connection'] = {
+#   'provider' => 'AWS',
+#   'region' => 'eu-west-1',
+#   'aws_access_key_id' => 'AKIAKIAKI',
+#   'aws_secret_access_key' => 'secret123'
+# }
+```
+
+Additional, check in the admin area:
+
+1. **Menu > Admin** On the left sidebar, select **Settings > Metrics and Profiling**, then expand
+   **Pseudonymizer data collection**.
+1. Is **Enable Pseudonymizer data collection** selected?
+
 ---
 
 ### `promote-to-primary-node` command from `gitlab-ctl`