Skip to content

GitLab

    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    • Menu
    Projects Groups Snippets
  • Get a free trial
  • Sign up
  • Login
  • Sign in / Register
  • BCHUnlimited BCHUnlimited
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 73
    • Issues 73
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 23
    • Merge requests 23
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • bitcoinunlimited
  • BCHUnlimitedBCHUnlimited
  • Merge requests
  • !2453

WIP: Make multiple OP_RETURN standard

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Nicolai Skye requested to merge nicolaiskye1/BCHUnlimited:multiple-op-return-as-standard into dev Mar 25, 2021
  • Overview 5
  • Commits 2
  • Changes 5

This change makes having multiple OP_RETURN outputs on a single transaction a "standard" transaction type. Without this change, multiple OP_RETURNs are considered non-standard and thus are typically not mined by miners.

This change has been discussed in depth here: https://bitcoincashresearch.org/t/multiple-op-returns-this-time-for-real/315

and a CHIP for it exists here: https://github.com/ActorForth/Auction-Protocol/blob/main/CHIP-2021-03-12_Multiple_OP_RETURN_for_Bitcoin_Cash.md

This merge request is marked as "WIP" because the dev branch currently lacks a check to ensure the new standard is only applied after the May 2021 network upgrade. A separate merge request to add such a check exists here: !2452 (closed)

Once such a check exists, one line of code needs to be adjusted in this merge request in order to utilize the check. Otherwise, the changes in this merge request work as expected, and pass the unit tests.

These changes were adapted from the code that user BigBlockIfTrue contributed to the Bitcoin Cash Node project.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: multiple-op-return-as-standard