Skip to content

mempool: Remove ancestor/descendant related stats from RPC

Calin Culianu requested to merge cculianu/bitcoin-cash-node:mempool/3_nuke_rpc_quadratic_stats into master

Note: This is part 3 in the series of mempool MR's. It builds on top of !1128 (merged) & !1127 (merged), and is broken out from !1114 (closed). If reviewing, review the topmost commit starting at "mempool: Remove ancestor/descendant related stats from RPC".

Summary

The mempool quadratic stats themselves will soon be removed in a future commit. However, we are removing them from RPC now in this commit to keep things manageable.

This commit removes the following stats from RPC:

  • "ancestor", "descendant", "descendantcount", "descendantsize", "descendantfees", "ancestorcount", "ancestorsize", "ancestorfees"
  • RPC's affected: getrawmempool true, getmempoolancestors, getmempooldescendants, getmempoolentry

Test Plan

  • ninja all check-all
  • Start a node, verify the above RPCs are missing the keys described (you may need to ensure some tx's are in the mempool first). (If you are unfamiliar with the output of these commands, maybe try it on master first to see the removed keys appear there).
  • Run RPC help for the above and ensure help is missing the keys mentioned above.
Edited by freetrader

Merge request reports