Skip to content

Unused preprocessor definitions

SlowRiot requested to merge SlowRiot/bitcoin-cash-node:unused_defines into master

This MR cleans up unused preprocessor defines found in the code.

  • #define NULLPTR(T) formerly used to work around a Boost Test issue, not currently used and not likely to be needed again.
  • #define SCRIPT_ERR_LAST marking the end of a set of enums. Not used, and redundant, as the end marker ScriptError::ERROR_COUNT is used instead.
  • Two unused win32 compatibility defines in compat.h

Out of scope

The following are defined and not currently used, but will not be removed:

  • threadsafety.h defines helper macros for attributes used for thread safety analysis; some of these are currently unused, but all are retained in anticipation of future use.
  • Tinyformat defines helper macros for variable argument counts; unused ones are retained.

Test plan

time ninja check-all

Verify there are no compiler warnings or errors generated, and tests pass.

Edited by SlowRiot

Merge request reports