Skip to content

Bug fix: Preventing a crash when clicking on some items in the "window" menu...

Evan Meakyl requested to merge emeakyl/bitcoin-cash-node:bug/crash-splash-screen-window-menu into master

Bug fix: Preventing a crash when clicking on some items in the "window" menu during application start-up

This commit fixes a bug introduced into 459b3bb5: qt: Add Window menu Some options in the menu are enabled while the node is initializing, and can lead to a crash if selected by the user.

The issue was reproduced and fixed on OSX, but the problem seems platform-independent.

How to reproduce

  • Run BitcoinCashNode-Qt
  • While the application is starting-up, go into the 'Window' menu, and select 'Console traffic'
  • The application will crash

What this fixes

The menu items are disabled while the application is initializing, and enabled once the initialization is over.

How to test

  • Run BitcoinCashNode-Qt
  • While the application is starting-up, go into the 'Window' menu, see that the items 'Main window', 'Information', 'Console', 'Network traffic' and 'Peers' are disabled.
  • Once the splash window vanishes, these items are enabled.

Merge request reports