Skip to content

GUI: Localise the decimal separator in amounts

BigBlockIfTrue requested to merge BigBlockIfTrue/bitcoin-cash-node:feature/i18n-amount into master

Following the introduction of localised decimal separators in !1009 (merged), this localises the decimal separator in amounts, in a conservative way. See src/qt/bitcoinunits.cpp for explanation and rationale.

Additionally:

  • Plus and minus signs can no longer be typed into an amount field (the thing is designed for unsigned numbers).
  • Modernised function signature of BitcoinUnits::parse, added allowComma parameter (false for BIP21 URIs).
  • Removed BitcoinUnits::maxMoney().

Test plan: test the Send/Receive tabs in the GUI (English and German), ninja check

Note: the thing on the Transactions tab is a generic float field, not an amount field, although it gets fed to the same parser.

Depends on: !1009 (merged)

Merge request reports