Skip to content
GitLab
  1. 23 Jun, 2020 1 commit
  3. 22 Jun, 2020 1 commit
    • sg35zh's avatar
      split test deps from prereq · 69f73d19
      sg35zh authored 
      rationale: on some systems, MYMETA.* is parsed in order to generate rpm
deps and those deps ends as runtime dependencies whereas they really are
builtime deps for tests
      69f73d19
  5. 10 May, 2020 6 commits
    • pali's avatar
      Do not autovivify inspector interfaces hash · 39653cc6
      pali authored and Daniel P. Berrangé's avatar Daniel P. Berrangé committed
      39653cc6
    • pali's avatar
      Add optional interface parameter for has_signal() method · 76b193bd
      pali authored and Daniel P. Berrangé's avatar Daniel P. Berrangé committed 
      Similar optional argument is already supported by has_property() method.
      76b193bd
    • pali's avatar
      Add some tests for dicts and variants · 3a2cf0a0
      pali authored and Daniel P. Berrangé's avatar Daniel P. Berrangé committed
      3a2cf0a0
    • pali's avatar
      Allow to call append() method with value in dbus_variant() decorator on interface with TYPE_VARIANT · 294ebb3a
      pali authored and Daniel P. Berrangé's avatar Daniel P. Berrangé committed 
      Method append_variant() expects raw (non-variant) value as its argument,
which is then put into DBus structure. So when variant value is provided,
first unpack it and then put it into append_variant() method.

This change fixes problem that Net::DBus created structure like
"variant of variant of variant string" instead of "variant of string".

Strictly typed applications do not expects that variant type is put in
another variant type.
      294ebb3a
    • pali's avatar
      Allow to call append_dict() method without specifying type · e1d6e2cd
      pali authored and Daniel P. Berrangé's avatar Daniel P. Berrangé committed 
      Method append_array() can be already called without type, so it make sense
to allow also append_dict() to call without specifying type.
      e1d6e2cd
    • pali's avatar
      Fix guess_type() method for dbus variants and hash values · 15f2d262
      pali authored 
      Do not try to guess type from the first hash key/value. It is incompatible
when you want to put into dbus dictionary perl hash with one scalar and one
non-scalar type. So rather return from guess_type() method just "generic"
[ &Net::DBus::Binding::Message::TYPE_VARIANT ] type without subtype.

Missing subtype would be filled later by subsequent guess_type() calls for
every one hash value. Also do not call guess_type() method on perl hash
keys as it does not make sense. In perl all keys in hashes are just
strings, so set type of keys in dbus dict to TYPE_STRING.

This change fixes libdbus crash when Perl application was trying to do DBus
method call with variable perl hash argument and guess_type() method was
used. libdbus in this case caused segfault of whole perl process:

    dbus[3876]: Array or variant type requires that type string be written, but uint16 was written.
    The overall signature expected here was 'oha{ss}' and we are on byte 5 of that signature.
      D-Bus not built with -rdynamic so unable to print a backtrace
    [1]    3875 abort
      15f2d262
  7. 16 Dec, 2019 7 commits
  9. 01 Dec, 2019 5 commits
  11. 20 Nov, 2019 10 commits
  13. 14 Nov, 2019 1 commit
    • pali's avatar
      Fix calculation of basepath when enumerating subnodes · c07984a8
      pali authored 
      basepath for root node is "/" and not "//". Root node is special case as it
ends with slash. This patch fixes it.

Also without this patch, Net::DBus generates warning:

Use of uninitialized value $1 in hash element at Net/DBus/BaseObject.pm line 244.
      c07984a8
  15. 12 Feb, 2019 1 commit
  17. 29 Oct, 2018 1 commit
  19. 25 Jan, 2018 3 commits
  21. 08 Jul, 2016 1 commit
  23. 21 Mar, 2015 1 commit
  25. 16 Mar, 2015 2 commits