Skip to content
Snippets Groups Projects

De magic ify

Merged Daniel Xue requested to merge de-magic-ify into master

Get rid of all magic numbers

  • Cell length (30cm)
    • Make movement distances based off of cell size (where it makes sense)
  • IR front back distance
  • Motor powers
  • Wall detection thresholds (will be done with reimplementation of wall detection #11 (closed) - !18 (merged))
  • Standardize parameters for relative directions using enumeration or such moved out to #23

Merge request reports

Pipeline #7607522 passed

Pipeline passed for 0a932d1f on de-magic-ify

Merged by Ethan WuEthan Wu 8 years ago (Apr 12, 2017 3:42pm UTC)

Merge details

  • Changes merged into master with d5754324.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #7607582 passed

Pipeline passed for d5754324 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading