Skip to content

Test against PHP 8.4 / dependency updates

PHP 8.4 tests fail at present, I believe due to unresolved indirect deprecations in dependencies.

$ vendor/bin/phpunit --colors=always --log-junit junit.xml
PHPUnit 9.6.22 by Sebastian Bergmann and contributors.
...............................................................  63 / 255 ( 24%)
............................................................... 126 / 255 ( 49%)
............................................................... 189 / 255 ( 74%)
............................................................... 252 / 255 ( 98%)
...                                                             255 / 255 (100%)
Time: 00:36.224, Memory: 14.00 MB
OK (255 tests, 549 assertions)
Remaining indirect deprecation notices (1)
  1x: WebSocket\ConnectionException::__construct(): Implicitly marking parameter $prev as nullable is deprecated, the explicit nullable type must be used instead
    1x in CookieTest::testHttpOnlyCookieIsDeleted from Behat\Mink\Tests\Driver\Basic

My understanding of this is that:

  • All tests pass
  • phrity/websocket has a deprecation notice here, which is in an older version of that library
  • We will need to make changes to use a more current release of phrity/websocket
Edited by Chris Burgess