Skip to content

Hide builder page and application to users other than builder

What is in this MR

This MR fixes the bug mentionned here: !2576 (comment 2020279961)

How to test this MR

  • Create a workspace with a few applications. Remove all pages to one of them.
  • Add a user with editor role
  • connect with this user. On develop you have the list of all created builder applications and you have access to all the pages of these applications. If you click on the application you can load it and a 404 page appears. You can also see all these applications in the dashboard.
  • Now checkout this branch, and migrate (even if there is no migration, the roles are synced by this operation). Restart the backend and frontend servers.
  • Reload the page, now the editor shouldn't be able to see the applications and the pages are not returned anymore with the application. The builder applications are still in the application payload but they are not visible in the sidebar nor on the dashboard.
  • Check that with builder and admin you have still access to all features like create a new builder application, create a new page, ...

Merge Request Checklist

  • A changelog entry has been created if required.
  • New/updated Premium/Enterprise features are separated correctly in the premium or enterprise folder
  • The latest Chrome and Firefox have been used to test any new frontend features
  • Documentation has been updated
  • Quality Standards are met
  • Performance: tables are still fast with 100k+ rows, 100+ field tables
  • The redoc API pages have been updated for any REST API changes
  • Our custom API docs are updated for changes to endpoints accessed via api tokens
  • The UI/UX has been updated following UI Style Guide
Edited by Jérémie Pardou

Merge request reports