Skip to content

FormGroup FormInput FormTextarea refactoring

Jonathan Adeline requested to merge form-input-refactor into develop

What is in this MR

This MR introduces a refactor of the FormGroup and FormInput components. FormGroup is basically a wrapper for any form input components. It manages the display of the label, error, warning and description messages around the input. The input is injected through the default slot.

FormInput component is used to render a form input field (text, number, password, email or url)

FormTextarea is a component that renders a textarea. The existing AutoExpandableTextarea has been merged into this one (thanks to an autoExpandable prop) and thus has been deleted.

How to test this MR

  • In Storybook, test the 3 components and all their variants. Check the different states match the design in Figma.
  • Test all the inputs replaced across the app and make sure they still work as expected.

Merge Request Checklist

  • changelog.md has been updated if required.
  • New/updated Premium/Enterprise features are separated correctly in the premium or enterprise folder
  • The latest Chrome and Firefox have been used to test any new frontend features
  • Documentation has been updated
  • Quality Standards are met
  • Performance: tables are still fast with 100k+ rows, 100+ field tables
  • The redoc API pages have been updated for any REST API changes
  • Our custom API docs are updated for changes to endpoints accessed via api tokens
  • The UI/UX has been updated following UI Style Guide

Closes #1877 (closed)

Edited by Jérémie Pardou

Merge request reports