Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • baserow baserow
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 554
    • Issues 554
    • List
    • Boards
    • Service Desk
    • Milestones
    • Requirements
  • Merge requests 14
    • Merge requests 14
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Baserow
  • baserowbaserow
  • Issues
  • #1321
Closed
Open
Issue created Nov 10, 2022 by Nigel Gott@nigel_baserowMaintainer

Ensure event handlers are never orphaned preventing clicking on cells

In #1085 (closed) we fixed on instance of a bug where a javascript event handler was registered, called event.preventDefault() and then was never unregistered, breaking clicks globally.

This bug has resurfaced again and we should fix the root cause. The root cause is that we often manually create our own custom event handlers and store them on literal DOM objects. We then rely on these event handler references being stored on the DOM element to unregister them at the appropriate time. This can fail in a large number of ways causing old event handlers to be never unregistered. We should figure out a much more robust way of adding and ensuring the unregistration of event handlers.

Assignee
Assign to
Time tracking