possibly superfluous includes
@rcurtin The main header file include/bandicoot
seems to have the following superfluous includes:
- <sys/types.h>
- <sys/stat.h>
- <pwd.h>
The first two (sys/types.h and sys/stat.h) are not part of the C++ standard. They are specific to POSIX.
"sys/types.h" provides various type definitions -- do we need them? Perhaps they are required by MAGMA? Types like std::size_t are already provided as part of the C++ standard.
https://pubs.opengroup.org/onlinepubs/007904875/basedefs/sys/types.h.html
"sys/stat.h" provides a definition of "struct stat", used by fstat(), lstat(), stat(). It also provides definitions of chmod(), fchmod(), fstat(), lstat(), mkdir(), mkfifo(), mknod(), stat(). Are any of these used by Bandicoot?
https://pubs.opengroup.org/onlinepubs/009604499/basedefs/sys/stat.h.html
The last one (pwd.h) is inside an ifdef guard for POSIX systems, but all it provides is a definition of "struct passwd", which doesn't seem relevant to Bandicoot: https://pubs.opengroup.org/onlinepubs/009695399/basedefs/pwd.h.html