Make code idiomatic for Foxy after 1.0 release
Description
After the release of 1.0, Foxy is the only supported distro. This will allow us to get rid of a bit of ugliness that is currently required to also support Dashing.
Definition of Done
-
Rename Node()
arguments in launch files so we don't get deprecation warnings for usingnode_executable
,node_name
andnode_namespace
-
Remove Dashing special casing in controller_base_node.cpp and elsewhere (search for ROS_DISTRO_FOXY
) -
Use RCLCPP_WARN_THROTTLE wherever appropriate -
Update documentation to remove the Dashing-specific sections -
Replace Dashing-specific hacks related to problems with transient_local
topics
Edited by Esteve Fernandez