Replace --abort-on-error with --return-code-on-test-failure in CI
Description
Currently, the coverage
job in the .gitlab-ci.yml
script runs the command colcon test --abort-on-error
. However, the description for this flag says: Abort after the first package with any errors (failing tests are not considered errors in this context)
. I think the intent was to cause the coverage
job to fail if any tests fail, which is not currently the case. Replacing this flag with --return-code-on-test-failure
should have the desired effect. Description of that flag: Use a non-zero return code to indicate any test failure
(which will cause the CI job to fail).
Expected behavior
The coverage
CI job should fail when a test failure occurs, rather than reporting an invalid coverage percentage.
Definition of Done
-
Replace --abort-on-error
with--return-code-on-test-failure
incoverage
CI job.