BuildResultFile does not use the right zlib.inflate "window" value
Turns out that were slightly off in our use of zlib.inflate
in BuildResultFile::unpackIntoTemporaryFile
. We were using window = 30
, which is almost right: base window size 14 (meaning the decompression buffer is 2^14 bytes) + 16 to use GZIP (which we produce through compress.zlib://
).
Unfortunately, the maximum window size (which is what compress.zlib://
uses!) is 2^15 bytes, so we should have specified 15 + 16 = 31 as the window. Interestingly enough, this would only be an issue with files > 16KiB, which is exactly what a failing run of the TestFX tests would produce: this is why this problem hadn't appeared until now!