No Warning/Error when 'fan_curve' not 'allowed' at asusctl daemon startup
Hi,
After an asusctl upgrade, my silent fan_curve
wasn't working anymore.
Details about the issue
I noticed No Warning/Error messages in the profile when 'fan_curve' not 'allowed' by 'yarn/rog_fan_curve' (out of these ranges : https://github.com/Yarn/rog_fan_curve/blob/cdf69454e2bd9cff1169a283ceb15beb12eeba35/rog_fan_curve/src/lib.rs#L226) at asusctl daemon startup
I was editing the fan_curve
by hand / manual configuration, by editing the /etc/asusd/asusd.conf
configuration file and restarting the asusctl daemon. No warning was displayed when setting "disallowed" values inside fan_curve
param list this way.
How to reproduce ?
But, after trying with the command line, a warning message was shown, example :
asusctl profile test_warn --create --curve "39c:0%,49c:0%,59c:0%,69c:0%,79c:5%,89c:0%,99c:0%,109c:0%"
source invalid argument to option `--curve`: Unsafe curve SpeedTooLow(4)
So, for all people that were using a "silent/fanless" fan_curve
before upgrading, after upgrading the profile will still be the same even if it's now marked as "disallowed" and profile will skip the fan_curve
without letting people know why... :(
Solution
Adding a warning message that explain at startup of the asusctl daemon if the fan_curve
is in the "disallowed/dangerous" settings range.