All available led-mode commands are not displayed with `asusctl led-mode --help`
A bug prevents some of the modes to be diplayed with asusctl led-mode --help
.
At https://gitlab.com/asus-linux/asusctl/-/blob/main/asusctl/src/main.rs#L358 , command.contains(&<&str>::from(mode).to_lowercase())
cannot match for some commands.
For example for the Strobe
command, command
is " strobe strobe through all colours"
while &<&str>::from(mode).to_lowercase()
is "strobing"
which will never match.
There is the same problem from the commands :
-
" highlight pressed keys are highlighted to fade"
(doesn't match"keypress highlight"
) -
" laser pressed keys generate horizontal laser"
(doesn't match"keypress laser"
) -
" ripple pressed keys ripple outwards like a splash"
(doesn't match"keypress ripple"
) - and in a different way
" breathe pulse between one or two colours"
which matches with"pulse"
instead of"breathing"
.
The problem is rooted at the conversion between str
and AuraModeNum
in https://gitlab.com/asus-linux/asusctl/-/blob/main/rog-aura/src/builtin_modes.rs and a loose way of matching commands usage with command name.