1. 16 Dec, 2016 3 commits
    • Timothy Andrew's avatar
      Implement final review comments from @rymai. · e394d287
      Timothy Andrew authored
      - `raise "string"` raises a `RuntimeError` - no need to be explicit
      - Remove top-level comment in the `RevList` class
      - Use `%w()` instead of `%w[]`
      - Extract an `environment_variables` method to cache `env.slice(*ALLOWED_VARIABLES)`
      - Use `start_with?` for env variable validation instead of regex match
      - Validation specs for each allowed environment variable were identical. Build them dynamically.
      - Minor change to `popen3` expectation.
      e394d287
    • Timothy Andrew's avatar
      Check the exit code while invoking git in the force push check. · c937aec1
      Timothy Andrew authored
      Previously, we were calling out to `popen` without asserting on the returned
      exit-code. Now we raise a `RuntimeError` if the exit code is non-zero.
      c937aec1
    • Timothy Andrew's avatar
      Accept environment variables from the `pre-receive` script. · f82d549d
      Timothy Andrew authored
      1. Starting version 2.11, git changed the way the pre-receive flow works.
      
        - Previously, the new potential objects would be added to the main repo. If the
          pre-receive passes, the new objects stay in the repo but are linked up. If
          the pre-receive fails, the new objects stay orphaned in the repo, and are
          cleaned up during the next `git gc`.
      
        - In 2.11, the new potential objects are added to a temporary "alternate object
          directory", that git creates for this purpose. If the pre-receive passes, the
          objects from the alternate object directory are migrated to the main repo. If
          the pre-receive fails the alternate object directory is simply deleted.
      
      2. In our workflow, the pre-recieve script (in `gitlab-shell) calls the
         `/allowed` endpoint, which calls out directly to git to perform
         various checks. These direct calls to git do _not_ have the necessary
         environment variables set which allow access to the "alternate object
         directory" (explained above). Therefore these calls to git are not able to
         access any of the new potential objects to be added during this push.
      
      3. We fix this by accepting the relevant environment variables
         (GIT_ALTERNATE_OBJECT_DIRECTORIES, GIT_OBJECT_DIRECTORY) on the
         `/allowed` endpoint, and then include these environment variables while
         calling out to git.
      
      4. This commit includes (whitelisted) these environment variables while making
         the "force push" check. A `Gitlab::Git::RevList` module is extracted to
         prevent `ForcePush` from being littered with these checks.
      f82d549d
  2. 13 Sep, 2016 1 commit
    • Paco Guzman's avatar
      Avoid protected branches checks when verifying access without branch name · 08871cc3
      Paco Guzman authored
      GitlabShell verify access sending ‘_any’ as the changes made on the git command, in those cases Gitlab::Checks::ChangeAccess won’t receive a branch_name so we don’t need to check for access to the 
      protected branches on that repository. So we avoid some git operations in case the are not cached (empty_repo?) and some database lookups to get protected branches.
      
      These request is happening in every push.
      08871cc3
  3. 12 Aug, 2016 1 commit
  4. 11 Aug, 2016 1 commit
    • Scott Le's avatar
      api for generating new merge request · 6109daf4
      Scott Le authored
      DRY code + fix rubocop
      
      Add more test cases
      
      Append to changelog
      
      DRY changes list
      
      find_url service for merge_requests
      
      use GET for getting merge request links
      
      remove files
      
      rename to get_url_service
      
      reduce loop
      
      add test case for cross project
      
      refactor tiny thing
      
      update changelog
      6109daf4
  5. 19 Jul, 2016 1 commit
  6. 18 Jul, 2016 1 commit
  7. 13 Jul, 2016 4 commits