Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
tlspool-gui
tlspool-gui
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 0
    • Merge Requests 0
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • arpa2
  • tlspool-guitlspool-gui
  • Merge Requests
  • !2

Merged
Opened Apr 28, 2020 by Adriaan de Groot@adriaandegrootMaintainer

Replace the custom version-string generation by ARPA2CM's

  • Overview 2
  • Commits 1
  • Changes 4

When using ARPA2CM's GET_PROJECT_GIT_VERSION macro, a header file is always written (even if there's no .git) with a suitable representation of the version number (obtained from PROJECT_VERSION if there is no git information).

The string looks like #define tlspool_gui_VERSION_STRING "v0.0.5-19-g259082b5" (There are also split-apart version components, but those are missing the tweak values "-19-g..."; they can be useful for numerical representations).

The generated static QString was being included in multiple places, so replacing that with a const char[] isn't a big deal (until we want to support translation of the About Box, at least).

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: arpa2/tlspool-gui!2
Source branch: change-version-string

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.