Skip to content
Snippets Groups Projects

WIP:Delete useless checks in confparse.c

Merged Taylor Yu requested to merge bug22103 into master

config_parse_interval() and config_parse_msec_interval() were checking whether the variable "ok" (a pointer to an int) was null, rather than derefencing it. Both functions are static, and all existing callers pass a valid pointer to those static functions. The callers do check the variables (also confusingly named "ok") whose addresses they pass as the "ok" arguments, so even if the pointer check were corrected to be a dereference, it would be redundant.

Fixes #22103.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading