Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • apparmor apparmor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 136
    • Issues 136
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • AppArmorAppArmor
  • apparmorapparmor
  • Merge requests
  • !804

binutils/aa-features-abi: fix a couple of minor issues

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Steve Beattie requested to merge smb/apparmor:binutils-aa_features_abi-misc-fixes into master Sep 27, 2021
  • Overview 1
  • Commits 2
  • Pipelines 3
  • Changes 1

A small patch set to fix two issues with binutils/aa-features-abi:

  1. The aa-features-abi -f short argument was not added to the getopt_long() set of short arguments, resulting in the command incorrectly failing when passed -f
  2. Due to variable shadowing the file descriptor for the --file argument was not being autoclosed.
  • binutils/aa-features-abi: make -f short arg actually be accepted
  • binutils/aa-features-abi: fix failure to close fd due to shadowed var decl

Nominated for both trunk and the apparmor-3.0 branch.

Signed-off-by: Steve Beattie steve.beattie@canonical.com

Edited Sep 27, 2021 by Steve Beattie
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: binutils-aa_features_abi-misc-fixes