Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • apparmor apparmor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 119
    • Issues 119
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 25
    • Merge requests 25
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • AppArmor
  • apparmorapparmor
  • Merge requests
  • !352

remove_profiles(): Fix returning $retval

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christian Boltz requested to merge cboltz/apparmor:cboltz-subshell into master Mar 15, 2019
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

Extend the subshell so that the actual (possibly non-zero) value of $retval gets returned. Before, the changed value was lost at "done" (= leaving the subshell), and the initial $retval=0 was returned.

(found with shellcheck)

Ignoring the whitespace fixes, the diff is:

- while ... return $retval
+ { while ... return $retval }

I propose this fix for 2.11..master

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: cboltz-subshell