AP-DailyGoal-260 (New)

apathyrequested to merge
ap-dailygoal-260new into main

Final

  • Rename Post/Poll/Thread "excluded_nodes" goal option -> "node_id"
  • Update permission IDs during upgrade
  • "Excluded nodes" are missing a "None" option
  • "None" option triggers an error: The error value must be a string or an object which can be cast to a string in src/XF/Mvc/Reply/Error.php at line 79

Testing 002

  • Test an upgrade
  • Test a fresh install
  • Siropu\Chat: Test excluded rooms option
  • UserUpgrade: Test user upgrade type limit
  • Thread: Test "replies only" toggle
  • Poll: Test excluded nodes option
  • Test periodicity toggle
  • Test if history deletion prompter works when deleting a goal
  • Test if an "addon goal"'s history is deleted when the relevant addon is uninstalled
  • Test a goals "Delete" button works

Testing 001

  • Siropu\Chat: Test excluded rooms option
  • UserUpgrade: Test user upgrade type limit
  • Thread: Test "replies only" toggle
  • Poll: Test excluded nodes option
  • Test periodicity toggle
  • Test if history deletion prompter works when deleting a goal
  • Test if an "addon goal"'s history is deleted when the relevant addon is uninstalled
  • Test a goals "Delete" button works

changelog

  • Siropu\Chat: Add option to exclude specified rooms from counting towards the goal
  • UserUpgrade: Add option to limit to specific type of upgrade
  • Thread: Add option to only count threads which have been replied to
  • Poll: Add option to exclude specified nodes from counting towards the goal
  • Create "Daily/Weekly" ("Periodicity") toggle
  • Prompt admin to delete history items when deleting a goal
  • Delete goal/streak history when the relevant supported addon has been uninstalled (e.g. delete article goal & its streak history when XenAddon's AMS has been uninstalled)
  • Add "delete" button to a goals options page
  • Some internal refactoring
  • Docblock code
Edited by apathy

Merge request reports