Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
MindTheWord
MindTheWord
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 76
    • Issues 76
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 50
    • Merge Requests 50
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • aossie
  • MindTheWordMindTheWord
  • Merge Requests
  • !500

Merged
Opened Jan 23, 2020 by Chidambaranathan Anirudh@c_anirudhContributor

fix popup options for firefox

  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

Fixes: #347 (closed)

The issue was caused by the tabs.getSelected() function which has been deprecated [source].

The function has been replaced with the tabs.query({active: true}) function in three places in popup.js. The blacklist/whitelist website button and switch extension on/off button in the popup now works in Mozilla Firefox.

Video illustrating working:

Untitled__Jan_22__2020_10_23_PM

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: aossie/MindTheWord!500
Source branch: firefox