Add overlay to mounts.
Like the transmog overlay
Mount Journal Documentation - https://github.com/Gethe/wow-ui-source/blob/live/Interface/AddOns/Blizzard_APIDocumentationGenerated/MountJournalDocumentation.lua
Mount Collection - https://github.com/Gethe/wow-ui-source/blob/live/Interface/AddOns/Blizzard_Collections/Blizzard_MountCollection.lua
Line 567
local numMounts = C_MountJournal.GetNumMounts();
MountJournal.numOwned = 0;
local showMounts = true;
local playerLevel = UnitLevel("player");
if ( numMounts < 1 ) then
-- display the no mounts message on the right hand side
MountJournal.MountDisplay.NoMounts:Show();
showMounts = false;
else
local mountIDs = C_MountJournal.GetMountIDs();
for i, mountID in ipairs(mountIDs) do
local _, _, _, _, _, _, _, _, _, hideOnChar, isCollected = C_MountJournal.GetMountInfoByID(mountID);
if (isCollected and hideOnChar ~= true) then
MountJournal.numOwned = MountJournal.numOwned + 1;
end
end
MountJournal.MountDisplay.NoMounts:Hide();
end
Better Transmog compatibility Fixed by SLOKnightfall today!
Moved item between the bank and the bags and the icon did not show up in the bags. It did clear from the bank.
Section Grid - doesn't work with sorting
Section Grid - first open of bank not showing everything
Error when switching to List mode.
9x CanIMogIt/Overlay/overlay.lua:69: attempt to call method 'GetName' (a nil value)
[string "@CanIMogIt/Overlay/overlay.lua"]:69: in function `CIMI_AddToFrame'
[string "@CanIMogIt/Plugins/betterbags.lua"]:15: in function <CanIMogIt/Plugins/betterbags.lua:10>
[string "@CanIMogIt/Plugins/betterbags.lua"]:40: in function `cb'
[string "@BetterBags/core/events.lua"]:45: in function <BetterBags/core/events.lua:40>
[string "=[C]"]: ?
[string "@BetterBags/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:19: in function <...ags/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>
[string "@BetterBags/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:54: in function `SendMessage'
[string "@BetterBags/core/events.lua"]:138: in function `SendMessage'
[string "@BetterBags/frames/bag.lua"]:226: in function `Draw'
[string "@BetterBags/core/init.lua"]:141: in function `cb'
[string "@BetterBags/core/events.lua"]:45: in function <BetterBags/core/events.lua:40>
[string "=[C]"]: ?
[string "@BetterBags/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:19: in function <...ags/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>
[string "@BetterBags/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:54: in function `SendMessage'
[string "@BetterBags/core/events.lua"]:148: in function <BetterBags/core/events.lua:147>
Locals:
parentFrame = <table> {
NormalTexture = BetterBagsItemButton563NormalTexture {
}
kind = 0
Stock = BetterBagsItemButton563Stock {
}
data = <table> {
}
LockTexture = BetterBagsItemButton563LockButton {
}
IconOverlay = Texture {
}
isFreeSlot = false
ilvlText = FontString {
}
Count = BetterBagsItemButton563Count {
}
button = BetterBagsItemButton563 {
}
IconQuestTexture = BetterBagsItemButton563IconQuestTexture {
}
frame = BetterBagsItemButton563parent {
}
Cooldown = BetterBagsItemButton563Cooldown {
}
IconTexture = BetterBagsItemButton563IconTexture {
}
}
updateIconFunc = <function> defined @CanIMogIt/Plugins/betterbags.lua:15
frameSuffix = nil
overrideIconLocation = nil
(*temporary) = <function> defined =[C]:-1
(*temporary) = nil
(*temporary) = <table> {
NormalTexture = BetterBagsItemButton563NormalTexture {
}
kind = 0
Stock = BetterBagsItemButton563Stock {
}
data = <table> {
}
LockTexture = BetterBagsItemButton563LockButton {
}
IconOverlay = Texture {
}
isFreeSlot = false
ilvlText = FontString {
}
Count = BetterBagsItemButton563Count {
}
button = BetterBagsItemButton563 {
}
IconQuestTexture = BetterBagsItemButton563IconQuestTexture {
}
frame = BetterBagsItemButton563parent {
}
Cooldown = BetterBagsItemButton563Cooldown {
}
IconTexture = BetterBagsItemButton563IconTexture {
}
}
(*temporary) = "attempt to call method 'GetName' (a nil value)"
ICON_SIZE = 13
Testing checklist (all icons display/update correctly):
Testing with a clean install alpha release (new Saved Variables, no other addons in the folder, and brand new CIMI folder)
Works as expected!
Sygon_Paul - https://legacy.curseforge.com/wow/addons/can-i-mog-it/issues/373
What happened?
Looking at CIMI's embeds.xml, the recommended loading order of the Ace3 libraries is not being followed. Some of the Ace3 libraries depend on others being loaded beforehand.
What did you expect to happen?
I have other addons that load Ace3 correctly, so I do not get errors. However, in a vacuum, CIMI might not work.
What version number of Can I Mog It is installed?
10.1.5v1.53
Are you using a Bag/Bank/UI addon? What version number is installed?
ElvUI 13.59, BetterBags 0.1.8
Other information
The recommended Ace3 load order in an addon's ToC file should match Ace3's ToC file, which you can see online here: https://github.com/WoWUIDev/Ace3/blob/master/Ace3.toc
Any Ace3 libraries that CIMI does not load or use can be ignored. if CIMI uses a .pkgmeta file, that does not need to match the Ace3 ToC, but it is suggested to keep the same pattern as CIMI's ToC file.
Sorry for being a pest. I want to help make CIMI the best it can be, in my own small way.
Follow-up: do not change the URLs in .pkgmeta to GitHub. Keep them from https://repos.curseforge.com/wow/ace3/trunk/TheAce3LibraryYouWant Only CIMI's ToC and embeds.xml need to change.
https://legacy.curseforge.com/wow/addons/can-i-mog-it/issues/374
pkgmeta is looking at incorrect URLs
What happened?
I was looking at issue #317 (closed) that fixed the load order of the Ace3 libs, good job! However, while pkgmeta and the ToC were updated to reflect the correct load order, pkgmeta is looking at URLs for LibStub, CallbackHandler-1.0, and Ace3 in the wrong places. When Twitch bought Curseforge, the URLs were changed; this is an easy thing to miss, and affected every addon and library hosted on Curseforge that uses their repo system rather than an external source.
Some of these libs have not had their description pages updated, so I am providing them here.
LibStub: https://repos.curseforge.com/wow/libstub/trunk
CallbackHandler-1.0: https://repos.curseforge.com/wow/callbackhandler/trunk/CallbackHandler-1.0
AceAddon-3.0: https://repos.curseforge.com/wow/ace3/trunk/AceAddon-3.0
AceEvent-3.0: https://repos.curseforge.com/wow/ace3/trunk/AceEvent-3.0
AceDB-3.0: https://repos.curseforge.com/wow/ace3/trunk/AceDB-3.0
AceConsole-3.0: https://repos.curseforge.com/wow/ace3/trunk/AceConsole-3.0
Your pkgmeta is looking at wowace URLs which no longer exist for these libraries. I am still a pest!
Edit: LibStub comes with an unnecessary child folder. You can add these lines to pkgmeta to strip out the child folder.
ignore: - LibStub/tests
Fixed in commit b4f2d892
Notes:
There are different layouts to check and support
Testing checklist (all icons display/update correctly):
Did not continue...
Address how the Appearance Sets count text overlaps with sets with more than 4.
AnkorionGaming requested a resize option on Curseforge: https://legacy.curseforge.com/wow/addons/can-i-mog-it/issues/355
Issue submitted to BetterWardrobe.
Sygon_Paul - https://legacy.curseforge.com/wow/addons/can-i-mog-it/issues/373
What happened?
Looking at CIMI's embeds.xml, the recommended loading order of the Ace3 libraries is not being followed. Some of the Ace3 libraries depend on others being loaded beforehand.
What did you expect to happen?
I have other addons that load Ace3 correctly, so I do not get errors. However, in a vacuum, CIMI might not work.
What version number of Can I Mog It is installed?
10.1.5v1.53
Are you using a Bag/Bank/UI addon? What version number is installed?
ElvUI 13.59, BetterBags 0.1.8
Other information
The recommended Ace3 load order in an addon's ToC file should match Ace3's ToC file, which you can see online here: https://github.com/WoWUIDev/Ace3/blob/master/Ace3.toc
Any Ace3 libraries that CIMI does not load or use can be ignored. if CIMI uses a .pkgmeta file, that does not need to match the Ace3 ToC, but it is suggested to keep the same pattern as CIMI's ToC file.
Sorry for being a pest. I want to help make CIMI the best it can be, in my own small way.
Follow-up: do not change the URLs in .pkgmeta to GitHub. Keep them from https://repos.curseforge.com/wow/ace3/trunk/TheAce3LibraryYouWant Only CIMI's ToC and embeds.xml need to change.
Address how the Appearance Sets count text overlaps with sets with more than 4.
AnkorionGaming requested a resize option on Curseforge: https://legacy.curseforge.com/wow/addons/can-i-mog-it/issues/355
Works great.
Only concern is how Better Wardrobe and Transmog copied our code for their plugin and the Sets overlay is messed up when both are enabled.
@toreltwiddler Please advise.
Address how the Appearance Sets count text overlaps with sets with more than 4.
AnkorionGaming requested a resize option on Curseforge: https://legacy.curseforge.com/wow/addons/can-i-mog-it/issues/355