Update alleleRowToggled to use .hasValidClassification instead of .hasClassification
Description
Closes issues: LA-1456 Related issues:
When the handling of outdated variants changed, the results from getClassification
also changed. Instead of classification.hasClassification
, it became classification.hasValidClassification
. The toggleAllele function was still using the old .hasClassification
, which is why it wasn't working. Fixed that and confirmed nowhere else was still using the old object field.
Notes to reviewer
Type of change
Application (affects UI or general functionality):
-
New feature -
Bug fix -
Improvement
Ops / admin / CI related only (not impacting users):
-
New feature -
Bug fix -
Improvement
Tests
General
-
Tests have been added that prove my fix is effective or that my feature works -
Related tests have been modified/removed
Hypothesis testing:
-
Soak testing has been done -
Distribution between positive / negative cases has been checked
Database
-
Includes changes to database schema -
Includes necessary database migrations
Configuration
-
Includes changes to configuration -
Includes configuration migration instructions in documentation
Merge checklist
-
Self-review of code performed -
Feature review against specification (if applicable) -
Need for documentation has been evaluated and, if necessary, updated -
Code and implementation is reviewed by other core developer (all changes, inc. changes based on initial review)
Closes #1456
Edited by Svein Tore Koksrud Seljebotn