Skip to content

Various ACMG improvements

Svein Tore Koksrud Seljebotn requested to merge acmg-indicators into dev

Description

Closes issues: LA-1394 LA-1427 LA-1448 LA-1393

Related issues:

Due to a lot of overlap between the issues, several issues are combined in this MR. In addition, ACMG indicators in the sidebar are added (no related issue).

See issue descriptions for more information.

Screenshot_from_2019-06-12_12-45-21

Notes to reviewer

Type of change

Application (affects UI or general functionality):

  • New feature
  • Bug fix
  • Improvement

Ops / admin / CI related only (not impacting users):

  • New feature
  • Bug fix
  • Improvement

Tests

General

  • Tests have been added that prove my fix is effective or that my feature works
  • Related tests have been modified/removed

Hypothesis testing:

  • Soak testing has been done
  • Distribution between positive / negative cases has been checked

Database

  • Includes changes to database schema
  • Includes necessary database migrations

Configuration

  • Includes changes to configuration
  • Includes configuration migration instructions in documentation

Merge checklist

  • Self-review of code performed
  • Feature review against specification (if applicable)
  • Need for documentation has been evaluated and, if necessary, updated
  • Code and implementation is reviewed by other core developer (all changes, inc. changes based on initial review)
Edited by Svein Tore Koksrud Seljebotn

Merge request reports