Edit reference assessment comment in reference list
Description
Closes issues: LA-1438 Related issues:
See issue description.
In addition:
- Also fixes a read only bug where you could edit the modal when alleleassessment was reused (has no impact as changes were not set in state).
- Also renames Save -> Close and removes Cancel buttons.
Notes to reviewer
src/webui/src/js/modals/referenceEvalModal.ngtmpl.html is reformatted, so a bit hard to see the diff. Only the buttons (on top of file) were changed.
Type of change
Application (affects UI or general functionality):
-
New feature -
Bug fix -
Improvement
Ops / admin / CI related only (not impacting users):
-
New feature -
Bug fix -
Improvement
Tests
General
-
Tests have been added that prove my fix is effective or that my feature works -
Related tests have been modified/removed
Hypothesis testing:
-
Soak testing has been done -
Distribution between positive / negative cases has been checked
Database
-
Includes changes to database schema -
Includes necessary database migrations
Configuration
-
Includes changes to configuration -
Includes configuration migration instructions in documentation
Merge checklist
-
Self-review of code performed -
Feature review against specification (if applicable) -
Need for documentation has been evaluated and, if necessary, updated -
Code and implementation is reviewed by other core developer (all changes, inc. changes based on initial review)
Edited by Svein Tore Koksrud Seljebotn