Skip to content

Fix issue when paginating in import modal

Svein Tore Koksrud Seljebotn requested to merge 1166-import-pagination-loop into dev

Description

Closes issues: LA-1166 Related issues:

See issue description. Bug is that the $watch fired since the type changed when the response came back, issuing a new request and then it ends up in a loop.

Notes to reviewer

There are no changes to importModal.ngtmpl.html, it's just been reformatted.

Type of change

  • New feature
  • Breaking change
  • Bug fix
  • Improvement

Tests

General

  • Tests have been added that prove my fix is effective or that my feature works
  • Related tests have been modified/removed

Hypothesis testing:

  • Soak testing has been done
  • Distribution between positive / negative cases has been checked

Database

  • Includes changes to database schema
  • Includes necessary database migrations

Configuration

  • Includes changes to configuration
  • Includes configuration migration instructions in documentation

General

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My branch has recently been updated with new changes in dev before this merge request
  • I have made corresponding changes to the documentation
Edited by Morten C. Eike

Merge request reports