Commit 25ebc4f2 authored by Alberto Bertogli's avatar Alberto Bertogli

Avoid unnecessary calls to fmt.Sprintf

The linter caught some unnecessary calls to fmt.Sprintf. This patch
removes them.

There are no functional changes.
parent d6b51216
......@@ -232,7 +232,7 @@ func (q *Queue) Remove(id string) {
func (q *Queue) DumpString() string {
q.mu.RLock()
defer q.mu.RUnlock()
s := fmt.Sprintf("# Queue status\n\n")
s := "# Queue status\n\n"
s += fmt.Sprintf("date: %v\n", time.Now())
s += fmt.Sprintf("length: %d\n\n", len(q.q))
......@@ -248,7 +248,7 @@ func (q *Queue) DumpString() string {
s += fmt.Sprintf(" last failure: %q\n", rcpt.LastFailureMessage)
}
item.Unlock()
s += fmt.Sprintf("\n")
s += "\n"
}
return s
......
......@@ -74,7 +74,7 @@ func TestDSNOnTimeout(t *testing.T) {
item := &Item{
Message: Message{
ID: <-newID,
From: fmt.Sprintf("[email protected]"),
From: "[email protected]",
Rcpt: []*Recipient{
mkR("[email protected]", Recipient_EMAIL, Recipient_PENDING, "err", "[email protected]")},
Data: []byte("data"),
......@@ -245,7 +245,7 @@ func TestSerialization(t *testing.T) {
item := &Item{
Message: Message{
ID: <-newID,
From: fmt.Sprintf("[email protected]"),
From: "[email protected]",
Rcpt: []*Recipient{
mkR("[email protected]", Recipient_EMAIL, Recipient_PENDING, "err", "[email protected]")},
Data: []byte("data"),
......
......@@ -606,7 +606,7 @@ func (c *Conn) DATA(params string) (code int, msg string) {
// the user keeps sending as commands, and that's a security
// issue.
readUntilDot(c.reader)
return 552, fmt.Sprintf("5.3.4 Message too big")
return 552, "5.3.4 Message too big"
}
return 554, fmt.Sprintf("5.4.0 Error reading DATA: %v", err)
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment