Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • aegir aegir
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 52
    • Issues 52
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • AegirAegir
  • aegiraegir
  • Merge requests
  • !3

Add basic entity types

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christopher Gervais requested to merge 5-basic-entity-types into master Dec 02, 2016
  • Overview 0
  • Commits 44
  • Pipelines 1
  • Changes 77

Closes #5 (closed)

While we'll need more entity types, this should be a good start. A few relatively simple rename/find/replace operations should be sufficient to generate a new type for now. We'll probably want to add a base AegirEntity from which our "real" ones can inherit, and/or extract some methods into traits, to reduce duplication. But that should probably wait until we have a few functional entities in place. Since we have reasonably full test coverage, such re-factoring should be pretty straight-forward.

Of course, this is a pretty big MR in terms of lines of code (~2700 lines). However, it's really just a revisionable, fieldable, translatable entity, along with everything that's required to test it. There isn't yet any Aegir-specific functionality.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 5-basic-entity-types