Rename core entity type classes etc.
In the existing codebase, all the core entity classes are named like Entity.php
and EntityType.php
across the board (platforms, sites, tasks, operations). These should be renamed to include the kind of entity they are in the class name.
For example:
-
\Drupal\aegir_operation\Entity\Entity
->\Drupal\aegir_operation\Entity\OperationEntity
-
\Drupal\aegir_platform\Entity\EntityType
->\Drupal\aegir_codebase\Entity\CodebaseEntityType
@colan suggested:
We've inherited the term "platform" from Aegir 3 to mean a codebase. Let's stop overloading this term as in the context, it generally means something else. Let's go with "codebase" for now, at least until we have a better term for it.
Remaining tasks:
-
Ensure we have good tests around all these core entity types. -
Identify all the class names that need renaming. -
Identify other things that need re-labeling? (eg. Distribution -> Application, Site -> App Instance) -
Search and replace terms in the code. -
Search and replace terms in the documentation.
Edited by Derek Laventure