Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • adblockplusui adblockplusui
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 247
    • Issues 247
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Adblock inc
  • Extensions
  • Adblock Plus
  • adblockplusuiadblockplusui
  • Issues
  • #998
Closed
Open
Created Jul 16, 2021 by Thomas Greiner@ThomasGreinerOwner

Introduce webext-sdk dependency

Background / User story

In order to be able to switch to the SDK (see #972 (closed)), we need to add webext-sdk as a new dependendy so that we can start using it.

What to change

  • Design: N/A
  • Research: N/A
  • Spec: N/A
  • Legal: N/A
  • Development:
    • Add vendor/webext-sdk submodule.
    • Update npm configuration to run npm install from repository's root directory.
    • Update READMEs and GitLab CI configuration accordingly.

Hints for testers

  • Extension builds (with and without snippets) should continue to generate successfully, both locally and in the CI.
    • Building the extension should also cause SDK bundles to be generated in the vendor/webext-sdk/dist/ directory, but they should not be included in extension builds.
  • It should continue to be possible to follow the extension build instructions in the README.
  • The webext-sdk git submodule should be resolved in the vendor/ directory.

Hints for translators

N/A

Edited Aug 16, 2021 by Thomas Greiner
Assignee
Assign to
Time tracking