Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • adblockplusui adblockplusui
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 269
    • Issues 269
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Adblock inc
  • Extensions
  • Adblock Plus
  • adblockplusuiadblockplusui
  • Issues
  • #976
Closed
Open
Created May 28, 2021 by Thomas Greiner@ThomasGreinerOwner

Language names not shown in settings page

Environment

  • OS version: Ubuntu 20.04
  • Browser version: Chrome 91
  • Extension version: Adblock Plus 3.11
  • Last working version: Adblock Plus 3.10.2

Steps to reproduce

Open desktop settings page.

Observed behavior

In "Language" section, filter list is shown as "EasyList (EasyList)".

Expected behavior

In "Language" section, filter list is shown as "English (EasyList)".

Further information

This regression was introduced in #939 (closed).

Hints for testers

This fix includes some refactoring. Therefore the following parts of the desktop settings page should also be checked, because they are related to the title resolution logic:

  • The subscription title should be correctly displayed throughout the page:
    • In General tab:
      • In "Recommended filters" section
      • In "Language filter lists" section (both in languages list and drop down list)
      • In "More filter lists" section
    • In Advanced tab:
      • In "Filter lists" section (both in table and drop down list)
  • Filters should be correctly displayed in the "Allowlisted websites" tab.
  • The correct title should be shown also when setting or changing a filter list's title:
    • It can be set when adding a custom filter list via subscribe links.
    • It can change after downloading a newer version of the filter list.
  • The option labels should be correctly displayed in the "Customizations" section.
Edited Jul 01, 2021 by Thomas Greiner
Assignee
Assign to
Time tracking