Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • adblockplusui adblockplusui
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 292
    • Issues 292
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Adblock incAdblock inc
  • ExtensionsExtensions
  • Adblock PlusAdblock Plus
  • adblockplusuiadblockplusui
  • Issues
  • #829
Closed
Open
Issue created Aug 13, 2020 by Thomas Greiner@ThomasGreinerOwner

Ignore notifications in case of data corruption

Background / User story

After a notification has been shown, the extension will mark it as such, in order to not show it again. However, it cannot do so for users who are experiencing data corruption problems. Therefore we should not show notifications, if we have detected any such problems.

There are some exceptions, though, because we want to continue to be able to notify users about the data corruption as well as about other critical topics. The latter cannot be dismissed anyway

What to change

  • Design: N/A
  • Research: N/A
  • Spec: https://gitlab.com/eyeo/specs/spec/-/merge_requests/346
  • Legal: https://jira.eyeo.com/browse/ABPUI-38
  • Development:
    • If extension identified a data corruption problem, it should not show any notifications, except:
      • Notifications with ID "problem".
      • Notifications with type "critical".

Hints for testers

No changes to adblockplusui have been made.

Hints for translators

N/A

Integration notes

Requires eyeo/adblockplus/adblockpluschrome#244 (closed) and https://gitlab.com/eyeo/adblockplus/adblockpluscore/-/issues/247.

Further information

We may be able to extend the shouldIgnoreNotifications() function, which is currently only used to enforce the user's preference to not see notifications.

Edited Sep 23, 2020 by Thomas Greiner
Assignee
Assign to
Time tracking