Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • adblockplusui adblockplusui
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 289
    • Issues 289
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Adblock incAdblock inc
  • ExtensionsExtensions
  • Adblock PlusAdblock Plus
  • adblockplusuiadblockplusui
  • Issues
  • #810
Closed
Open
Issue created Jun 26, 2020 by Ursa Kacar@ursakacarMaintainer

Page counter visible on non-HTTP(S) sites

Environment

  • OS version: Windows 10, Ubuntu 18.04
  • Browser version: Firefox, Chrome, Edge, but I don't think it's browser specific
  • Extension version: ui-release-2019-4
  • Last working version: ABP 3.8

Steps to reproduce

  1. On the first run page, open the popup

Observed behavior

Both counters are visible: on this page and total under total items blocked section

(The same behavior can be observed in all extension pages and in chrome pages, for example chrome://extensions/)

Expected behavior

On non https pages, only the total counter should be visible under total items blocked, see spec: https://gitlab.com/eyeo/specs/spec/-/blob/abp-ui-release-2019-4/spec/abp/popup.md#inactive

Further information

  • might be caused by https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/-/issues/806, since it was explicitly mentioned in the testing scope 🙂

Hints for testers

Elements should be shown/hidden as expected, if the user disabled ad blocking for the page.

Edited Jun 26, 2020 by Thomas Greiner
Assignee
Assign to
Time tracking