Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • adblockplusui adblockplusui
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 290
    • Issues 290
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Adblock incAdblock inc
  • ExtensionsExtensions
  • Adblock PlusAdblock Plus
  • adblockplusuiadblockplusui
  • Issues
  • #642
Closed
Open
Issue created Nov 29, 2019 by Andrea Giammarchi@agiammarchi

China: Number of items blocked social media sharing

Background / User story

As follow up of https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/409, and to complete https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/485, we need to take into account UI and logic/behavior for China market. We should show to Chinese speakers both: Weibo, Facebook and Twitter, in case the user is out of Chine, as we can't know what is their location.

What to change

  • Design: TBD
  • Research: TBD
  • Spec: https://gitlab.com/eyeo/specs/spec/merge_requests/308

Hints for testers

For Chinese locales, Weibo icon should be present in the popup, next to the Facebook and Twitter for sharing the total number of blocked ads to social media.

Hints for translators

  • Ensure titles are in Chinese.
  • Text for sharing on Twitter must not exceed 280 characters (incl. link and user name).

Integration notes

This is a followup issue for https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/409. It will require adding the new asset to link to Weibo in the adblockpluschrome repository.

Edited Aug 10, 2020 by Ursa Kacar
Assignee
Assign to
Time tracking