You need to sign in or sign up before continuing.
Inconsistent behavior when whitelisting page outside of icon popup
Environment
- OS version: Ubuntu 16.04
- Browser version: Chrome 78
- Extension version: UI release 2019-3
- Last working version: N/A
Steps to reproduce
- Add custom filter
@@||example.com/foo^$document
either directly or via a custom filter list. - Go to example.com/foo.
Scenario A
- Open icon popup.
- Disable Adblock Plus for example.com.
- Enable Adblock Plus for example.com.
Scenario B
- Open "Whitelisted websites" tab in desktop settings page.
- Add "example.com".
- Remove "example.com".
Scenario C
- Open mobile settings page.
- Disable Adblock Plus for example.com.
- Enable Adblock Plus for example.com.
Observed behavior
- Scenario A: Custom filter is not active (i.e. it's gone).
- Scenario B: Custom filter is active (i.e. it still exists).
- Scenario C: Custom filter is active (i.e. it still exists).
Expected behavior
Custom filter is not active (i.e. it's gone) in all three scenarios.
Further information
We use the "filters.unwhitelist" message in the icon popup, when en-/disabling Adblock Plus, which not only removes the respective exception rule but also gets rid of any other filters that whitelist the current page. In the other two places, however, we merely remove the exception rule.
Therefore we should use "filters.whitelist" and "filters.unwhitelist" instead of "filters.add" and "filters.remove" when en-/disabling Adblock Plus for a given domain/page.
Edited by Thomas Greiner