AA Survey dialog is flickering when selecting no 3-rd party tracking list

Environment

  • OS version: Mac OS v 10.14.6 (Mojave)
  • Browser version: Chrome 76.0.3809.132
  • Extension version: Latest dev builds (release-2019-1)

Steps to reproduce

  1. Open general tab of the options page
  2. Click on Only allow ads without third-party tracking checkbox

Observed behavior

Survey dialog is flickering before the checkbox is selected. flickerring

Expected behavior

No flickering dialog

Further information

Probably related to -> https://issues.adblockplus.org/ticket/5879 [edit: this issue is no longer relevant as the UI has changed]

Ideally, we would like to have support for transactions provided by adblockpluscore to allow us to add/remove multiple filter lists in an atomic action. However, for the time being, we can work around this either by a delay or by waiting for both actions to finish before determining whether or not to show the dialog.

Edited by Sadie Braun