Activation error for some users with non-Western character browser languages
Environment
- OS version: defect not OS specfic
- Browser version: defect not browser specific
- Extension version: It looks like it was this commit that created the defect: https://gitlab.com/adblockinc/ext/adblockplus/adblockplusui/-/blob/next/src/premium/content/activation.ts#L54
- Last working version: ?
Steps to reproduce
- get a premium license on browser A (or get a premium license and then uninstall the extension)
- on browser B, change your browser language to one that uses non-western characters (Greek, Russian, Japanese, etc.)
- open page: https://accounts.adblockplus.org/en/premium
- click:
Already have premium or contributed before? Activate here - enter the email you used for creating the license in step 1
- Enter the code you receive in an email
Observed behavior
- the error message "We're very sorry about the inconvenience. This error has been recorded and will be investigated by our developers as soon as possible. Please contact [support@adblockplus.org]" message will be shown
- premium will not be activated in the extension
Expected behavior
- Premium should be activated
Hints for testers
Until the bug in the engine is fixed, this change is implementing a fallback behavior for languages that don't have a default language list, where it attempts to install the following filter lists individually during initialization:
- EasyList (ID: 8C13E995-8F06-4927-BEA7-6C845FB7EEBF)
- Acceptable Ads (ID: 0798B6A2-94A4-4ADF-89ED-BEC112FC4C7F)
- Anti-circumvention filter list (ID: D4028CDD-3D39-4624-ACC7-8140F4EC3238)
Edited by Thomas Greiner