Skip to content

UI pages broken when upgrading from 3.14.2 to 3.15 in Firefox private mode

Environment

  • OS version: Ubuntu 18.04
  • Browser version: Firefox 104.0, Firefox Nightly 106.0a1 -> only with 'always use private mode' setting on
  • Extension version: 3.15
  • Last working version: /

Steps to reproduce

  1. open Firefox preferences, navigate to Privacy and select the 'Always use private browsing mode' checkbox
  2. install upacked version of ABP 3.14.2, you can download it from here: https://gitlab.com/eyeo/adblockplus/downloads/-/blob/master/adblockplusfirefox-3.14.2.xpi
  3. in about:addons, click the 'manage' option in the dropdown menu for ABP and select 'Allow' next to 'Run in Private Windows'
  4. upgrade ABP (I do that by replacing the files in the unpacked folder) to the build created from the latest 'release' branch, you can download the build here: https://gitlab.com/adblockinc/ext/adblockplus/adblockplusui/-/jobs/3080982408
  5. reload the extension

Observed behavior

  • first run page is opened
  • open the popup & options page- noticed the elements are not positioned correctly

image

Expected behavior

  • first run page should not be opened when extension is upgraded
  • UI pages should initialize correctly

Further information

  • adblocking works and correct filterlists are installed (this didn't work before, see SDK issue: https://gitlab.com/eyeo/adblockplus/abc/webext-sdk/-/issues/231
  • fresh install of the build from the latest release branch does not have this issue, only when upgrading
  • I was only able to reproduce this when having setting in FF set to 'Always use private browsing'
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information