Source Sans Pro is not supported by all priority languages
Background
@jeenlow Determined the priority languages for ABPUI, but apparently Source Sans Pro
is not supported by some of them.
Some languages are not supported by those priority languages.
What to do
- Use Athiti for
th-TH
. - Use Cairo for
ar
- Use Source Sans Pro for Latin (Extended), Cyrillic(Extended), Greek (Extended) and Vietnamese.
Notes
Extracting subset
In order to extract subset from the font use fonttools, the usage is as easy as:
pyftsubset DejaVuSans-ExtraLight.ttf --unicodes=U+0530-058F --output-file=armenian.ttf
Generating locale ranges
Use local-range in order to generate local ranges to keep the generated font file size minimal.
CJK
We decided to exclude CJK fonts for now, because even though we use Unicodes range it adds 1.5mb into output, which probably might have impact still on the final bundle size.
Hints for testers
There were couple of issues that went unnoticed in the current review, but were fixed separately which are still related to current issue:
- https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/342
- https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/321
- https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/350
Current comment is also relevant as a note.
Integration notes
- Add the following imports:
- adblockplusui/skin/fonts/300/Athiti.woff2
- adblockplusui/skin/fonts/300/Cairo.woff2
- adblockplusui/skin/fonts/300/SourceSansPro.woff2
- adblockplusui/skin/fonts/400/Athiti.woff2
- adblockplusui/skin/fonts/400/Cairo.woff2
- adblockplusui/skin/fonts/400/SourceSansPro.woff2
- adblockplusui/skin/fonts/700/Athiti.woff2
- adblockplusui/skin/fonts/700/Cairo.woff2
- adblockplusui/skin/fonts/700/SourceSansPro.woff2
- adblockplusui/skin/fonts/font.css
- Remove the following imports:
- adblockplusui/skin/fonts.css
- adblockplusui/skin/fonts/Source-Sans-Pro/300/cyrillic-ext.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/300/cyrillic.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/300/greek-ext.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/300/greek.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/300/latin-ext.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/300/latin.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/300/vietnamese.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/400/cyrillic-ext.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/400/cyrillic.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/400/greek-ext.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/400/greek.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/400/latin-ext.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/400/latin.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/400/vietnamese.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/700/cyrillic-ext.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/700/cyrillic.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/700/greek-ext.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/700/greek.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/700/latin-ext.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/700/latin.woff2
- adblockplusui/skin/fonts/Source-Sans-Pro/700/vietnamese.woff2
- Add
fonttools
andbrotli
as a dependency toadblockpluschrome:README.md
and update the build pipeline accordingly