Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    • Menu
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • adblockplusui adblockplusui
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 247
    • Issues 247
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Adblock inc
  • Extensions
  • Adblock Plus
  • adblockplusuiadblockplusui
  • Issues
  • #1063
Closed
Open
Created Dec 15, 2021 by Thomas Greiner@ThomasGreinerOwner

Support new filter validation errors from adblockpluscore 0.5

Background / User story

We wanted to upgrade the adblockpluscore dependency to 0.5 in #929 (closed), but decided to skip it and include that upgrade as part of #929 (closed), where we upgrade the webext-sdk dependency, which brings with it adblockpluscore 0.5. Nevertheless, we need to add error messages corresponding to new filter validation errors that it introduces.

What to change

  • Design: N/A
  • Research: N/A
  • Spec: eyeo/specs/spec!384
  • Legal: N/A
  • Development: Add support for "filter_url_not_specific_enough" and "filter_elemhide_not_specific_enough" filter validation errors.

Hints for testers

If a custom filter is invalid, because it includes an unknown option, the "filter_unknown_option" error message should be shown. However, if a known option that requires a value is used (e.g. "rewrite"), but no value is given, the "filter_invalid_option" error message should be shown instead.

Hints for translators

  • Added strings:
    • filter_elemhide_not_specific_enough
    • filter_url_not_specific_enough
  • Updated strings:
    • filter_slow
Edited Feb 01, 2022 by Thomas Greiner
Assignee
Assign to
Time tracking