Skip to content
GitLab
Closed
Created by Thomas Greiner@ThomasGreinerOwner

Stop relying on content filtering functionality for previewing new filters

Background / User story

In https://gitlab.com/eyeo/webext/webext-sdk/-/issues/80 , we discussed whether the SDK should/can provide us with the ability to apply new filters to websites, which we're using for the Block element feature, when the user decides to the add the filters from the dialog. Comparing the various alternatives, the quickest approach to make up for the loss of that ability, is to reuse the existing filter preview functionality, which is a rough representation of the effects the filters will have on the page when they're applied.

There are some problems with this approach (see comment, #824, #1032), but those may only concern edge cases and can be resolved with a page reload. Nevertheless, we should adjust the Block element dialog UI accordingly, so that users don't have wrong expectations about what happens when adding the filters via that dialog - especially if they have made modifications to the suggested filters.

What to change

Hints for testers

Clicking on "Block & reload page" button should not enable the filter preview before reloading the page.

Hints for translators

Added "composer_block_reload" string.

Edited by Thomas Greiner