Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • adblockplusui adblockplusui
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 266
    • Issues 266
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Adblock incAdblock inc
  • ExtensionsExtensions
  • Adblock PlusAdblock Plus
  • adblockplusuiadblockplusui
  • Issues
  • #1026
Closed
Open
Issue created Sep 15, 2021 by Alexandru Daniel Roman@a.roman

Update abp-snippets dependency to 0.3.1

Background / User story

We want to update the extension to use the latest version of abp-snippets to make use of the new snippets architecture and to introduce a new snippet.

Dependency changes

  • Name: abp/snippets
  • New version: 0.3.1 - commit 41d7d719
  • Breaking changes:
    • New snippets architecture
    • Removed dir-string snippet
  • Other changes:
    • Added new snippet: hide-if-graph-matches
    • New distributable: dist/ml/bundle.ml.mjs to replace both adblockpluscore/lib/ml.js and adblockpluschrome/lib/ml.js

  • Name: adblockpluscore
  • New version: tag 0.4.0 - commit fa0bb0c0
  • Other changes:
    • Fixed adblockpluscore#302 - remove snippets code
    • Fixed adblockpluscore#362 - inject snippets as bundles
    • Includes adblockpluscore 0.3.1:
      • Fixed adblockpluscore#332 - Nordic filters now supports Finnish
      • Fix adblockpluscore#304 - Abtest comment implemented
      • Fixed adblockpluscore#249 - Added Swedish language to Nordic list subscription

Integration changes

  • Development:
    • Adjust code in the following files accordingly, to load the new snippets bundles
      • adblockpluschrome/build/config/base.js
      • adblockpluschrome/lib/contentFiltering.js
    • Remove adblockpluschrome/lib/ml.js
    • Adjust code in the following files accordingly, to change the location of the ML dependency
      • adblockpluschrome/build/config/base.js
    • Change tensorflow/tfjs version to 3.7.0. No longer needs tensorflow/tfjs-converter and tensorflow/tfjs-core submodules added seperately. Previously this required manually combining functions/properties from both modules.
    • Ensure that users without access to private dependency, are still able to generate extension builds, albeit without snippets.

Hints for testers

Same as here.

See also https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/-/issues/990#hints-for-testers.

Edited Oct 22, 2021 by Georgiana Piscoi
Assignee
Assign to
Time tracking