What to do with FRP auto-opening in end-to-end test
Background / User story
With https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/-/merge_requests/533 we have introduced basis of end to end tests. There we are using a helper extension to opens an extension page in order to extract extension origin, to be able to open local extension pages. Technically we don't necessarily need the arbitrary timer as you can see from the current discussion. The problem is that when we implement suggestion in the discussion, the tests are being executed fine, but the progress visually is getting blocked by the FRP, as can see in the comment here.
So far we have several solutions with their cons:
- Keep timer(current solution)
- Slows the tests
- Remove timer
- FRP hides the progress visually
- Harder to debug
- Remove timer and prevent FRP from opening by a flag
- Most of the users doesn't have that experience.
- Wait until the FRP is open (previous solution)
- In #833 (closed) we stopped opening the local FRP, which makes it more difficult to identify
As agreed in the current discussion we will Remove timer and prevent FRP from opening by a flag
.
What to change
- Design: N/A
- Research: N/A
- Spec: N/A
- Legal: N/A
-
Development:
Remove timer and prevent FRP from opening by a flag
Hints for testers
N/A
Hints for translators
N/A
Integration notes
N/A
Edited by Manvel Saroyan